Closed osmansufy closed 4 weeks ago
The changes in this pull request involve modifications to the Assets
class in the includes/Assets.php
file, enhancing the localization of frontend scripts for the Dokan plugin. Specifically, the enqueue_front_scripts
method now includes additional localized data for the dokan-util-helper
script. The conditional_localized_args
method has also been updated to improve localization for user interface elements. Additionally, code style improvements have been made in the src/admin/main.js
file, focusing on formatting without altering functionality. A new ESLint configuration file has been introduced to ensure code quality.
File | Change Summary |
---|---|
includes/Assets.php |
Updated enqueue_front_scripts to localize dokan-util-helper script with additional parameters; modified conditional_localized_args for improved localization. |
src/admin/main.js |
Improved code style: added semicolons, adjusted spacing around function arguments, reformatted arrow functions, and ensured readability without changing functionality. |
.eslintrc |
New ESLint configuration file created to extend recommended settings from @wordpress/eslint-plugin . |
Objective | Addressed | Explanation |
---|---|---|
Geolocation map should appear on both the Shop and Store pages (#3724) | ❌ | The changes do not address the geolocation map issue directly. |
includes/Assets.php
file, specifically updating the localization handling for various scripts, which directly relates to the changes made in the enqueue_front_scripts
and conditional_localized_args
methods in the main PR. Both PRs focus on enhancing the localization capabilities for frontend scripts in the Dokan plugin.QA approved
, Upcoming Release
🐰 In the code where rabbits play,
Localization found its way.
Scripts now dance with data bright,
Enhancing features, what a sight!
With style refined, we hop along,
In the world of code, we all belong! 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Scenario: user login popup doesn't load for guest customers while submitting an abuse report
Steps to reproduce:
Screenshot:
All Submissions:
Changes proposed in this Pull Request:
Related Pull Request(s)
Closes
How to test the changes in this Pull Request:
Changelog entry
Title
Detailed Description of the pull request. What was previous behaviour and what will be changed in this PR.
Before Changes
Describe the issue before changes with screenshots(s).
After Changes
Describe the issue after changes with screenshot(s).
Feature Video (optional)
Link of detailed video if this PR is for a feature.
PR Self Review Checklist:
FOR PR REVIEWER ONLY:
Summary by CodeRabbit
New Features
dokan-util-helper
script, improving access to settings and configurations on the frontend.Style