getdokan / dokan

Multivendor marketplace platform
https://wordpress.org/plugins/dokan-lite/
259 stars 204 forks source link

Fix flaky tests #2411

Closed shashwatahalder01 closed 1 month ago

shashwatahalder01 commented 1 month ago

All Submissions:

Changes proposed in this Pull Request:

Related Pull Request(s)

Closes

How to test the changes in this Pull Request:

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 1 month ago

Walkthrough

The pull request includes updates to the package.json for the dokan_e2e_api_automation_playwright project, focusing on version upgrades for various development dependencies and dependencies. Additionally, modifications were made across several test files, including changes to method implementations, the addition of new test cases, and updates to existing tests to improve functionality and maintainability. Notably, there are enhancements in the handling of shipping methods and product management tests, ensuring better coverage and functionality in the testing framework.

Changes

File Path Change Summary
tests/pw/package.json Updated versions of multiple development dependencies and dependencies, including @types/node, @typescript-eslint/eslint-plugin, eslint-plugin-playwright, and others.
tests/pw/pages/productsPage.ts Modified cantAddGreaterMin method to change input from Escape to Tab for validation; updated method signature.
tests/pw/pages/selectors.ts Renamed parameters in selector.auction methods from name to productName for consistency.
tests/pw/pages/vendorAuctionsPage.ts Enhanced goToAuctionProductEdit and updateAuctionProductFields methods to improve UI test reliability and allow editing of date fields.
tests/pw/tests/api/_env.setup.ts Added methodId variable for capturing shipping zone method identifier; removed commented-out sections related to payment gateway updates.
tests/pw/tests/e2e/_env.setup.ts Updated shipping zone method handling to capture methodId during setup; removed commented-out payment gateway lines.
tests/pw/tests/e2e/coupons.spec.ts Added test.skip for vendor's coupon viewing test and test.slow() for customer coupon buying test.
tests/pw/tests/e2e/productAddons.spec.ts Added test.slow() to the product addon test case.
tests/pw/tests/e2e/products.spec.ts Added test.slow() to the downloadable product test case.
tests/pw/tests/e2e/productsDetails.spec.ts Introduced multiple test cases for product management functionalities, covering various vendor actions and validations.
tests/pw/tests/e2e/wholesale.spec.ts Added test.skip to multiple wholesale-related tests, indicating they are disabled for future fixes.
tests/pw/utils/apiUtils.ts Removed shippingMethodExistOrNot method; added methods for managing shipping zone methods, including getSingleShippingZoneMethod, updateShippingZoneMethod, and deleteShippingZoneMethod.
tests/pw/utils/payloads.ts Removed PRODUCT_ID and CATEGORY_ID from process.env; added addShippingMethodFlatRateCost property to payloads object.
tests/pw/utils/schemas.ts Updated admin_url field in abuseReportSchema from non-nullable to nullable string.

Possibly related PRs

Suggested labels

:+1: Dev Review Done

Suggested reviewers

Poem

🐰 In the garden of code, changes bloom bright,
With dependencies updated, everything feels right.
Tests for products now dance in a row,
Ensuring our features continue to grow.
So hop along, let’s celebrate this feat,
For a smoother journey, our code is now neat! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.