Fix admin fixed commission setting validation

Restrict admin commission percentage from 0 to 100

All Submissions:

[ ] My code follow the WordPress' coding standards
[ ] My code satisfies feature requirements
[ ] My code is tested
[ ] My code passes the PHPCS tests
[ ] My code has proper inline documentation
[ ] I've included related pull request(s) (optional)
[ ] I've included developer documentation (optional)
[ ] I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

Full PR Link

Closes

Closes #

How to test the changes in this Pull Request:

Steps or issue link

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

Code is not following code style guidelines
Bad naming: make sure you would understand your code if you read it a few months from now.
KISS: Keep it simple, Sweetie (not stupid!).
DRY: Don't Repeat Yourself.
Code that is not readable: too many nested 'if's are a bad sign.
Performance issues
Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

[ ] Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
[ ] Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
[ ] Readable — Will your future self be able to understand this change months down the road?
[ ] Elegant — Does the change fit aesthetically within the overall style and architecture?

Summary by CodeRabbit

Release Notes

New Features
- Enhanced validation for pricing settings, ensuring commission percentages are within the range of 0 to 100.
- Improved error handling for commission setup, defaulting to 0 if invalid input is detected.
- Added a new validation method in the CombineInput component to ensure percentage values are valid.
Bug Fixes
- Corrected input handling in the CombineInput component to ensure only valid percentage values are processed.
Documentation
- Updated documentation comments for new validation methods to clarify purpose and parameters.
Style
- Minor formatting adjustments for consistency across the codebase.

Walkthrough

The changes involve significant updates to the Settings and SetupWizard classes, focusing on the validation of pricing and commission settings. The format_price_values method has been replaced by validate_fixed_price_values, which enforces stricter validation rules for price settings. Additionally, the dokan_setup_commission_save method has been enhanced to validate commission percentages before saving. Minor adjustments were made to the CombineInput component to improve input validation and formatting. Overall, the modifications enhance the robustness and reliability of settings handling.

Changes

File	Change Summary
includes/Admin/Settings.php	- Removed method: `format_price_values` - Added method: `validate_fixed_price_values` - Updated filter to use new validation method and changed return type from `void` to `array`.
includes/Admin/SetupWizard.php	- Updated `dokan_setup_commission_save` method to include validation for commission percentage input, ensuring it is within the range of 0 to 100.
src/admin/components/CombineInput.vue	- Updated `watch` property and `onInput` method for improved validation and formatting of input values. - Corrected property name from `fixexName` to `fixedName`.

Suggested reviewers

mrabbani

🐇 In the land of code, where changes bloom,
New validations rise, dispelling the gloom.
Prices and commissions, all in their place,
With checks in the code, we quicken the pace.
A hop and a skip, through logic we glide,
In the world of settings, let clarity abide! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

getdokan / dokan