Break before make - Githubissues

geteduroam / apple-app

This app for iPhone, iPad and Mac configures devices for use with the eduroam network.

https://geteduroam.app/

BSD 3-Clause "New" or "Revised" License

6 stars 2 forks source link

Break before make #40

Closed johankool closed 1 year ago

johankool commented 1 year ago

@pauldekkers reported that configurations were removed too early.

pauldekkers commented 1 year ago

The connection appears to be removed as soon as the username/password prompt comes up; so after selecting an IdP, possibly selecting a profile, and accepting terms & conditions.

It disconnects between the first two images:

... while I kind of expected this to happen after the final "connect" click. (A user may have mis-clicked a profile, or is maybe just browsing around, or demo-ing like I did ;-))

johankool commented 1 year ago

@RianneBoortman can QA this, though perhaps @pauldekkers can do so more easily as he reported the issue.

RianneBoortman commented 1 year ago

Tested on:

iPhone 12 Pro Max, iOS 17 (public beta 3) Version:
TestFlight geteduroam Test version 2.0(47)

To me, it looks good! I see that the wifi connection is trying to be established when I click on "connect". But can you double check this too @pauldekkers ?