geteduroam / apple-app

This app for iPhone, iPad and Mac configures devices for use with the eduroam network.
https://geteduroam.app/
BSD 3-Clause "New" or "Revised" License
6 stars 2 forks source link

Fix typos found by codespell #65

Closed DimitriPapadopoulos closed 9 months ago

DimitriPapadopoulos commented 9 months ago

You won't be able to see the changes in the JSON file online, it's a huge 2.1 MB one-liner.

To see the changes, do as follows:

$ git checkout main
$ python3 -m json.tool geteduroam/discovery.json  > geteduroam/discovery.json.OLD
$ 
$ git checkout codespell
$ python3 -m json.tool geteduroam/discovery.json  > geteduroam/discovery.json.NEW
$ 
$ diff geteduroam/discovery.json.OLD geteduroam/discovery.json.NEW 
2811c2811
<                     "any": "Opole University of Technnology",
---
>                     "any": "Opole University of Technology",
2893c2893
<                     "any": "Technical Univeristy of Lodz",
---
>                     "any": "Lodz University of Technology",
30604c30604
<                     "en": "Academy of Perfoming Arts in Prague"
---
>                     "en": "Academy of Performing Arts in Prague"
40535c40535
<                     "any": "Wroclaw University of Enviromental and Life Sciences",
---
>                     "any": "Wroclaw University of Environmental and Life Sciences",
75640c75640
<                     "any": "Univeristy of Kelaniya"
---
>                     "any": "University of Kelaniya"
77618c77618
<                     "any": "Faculty of Medicine, Univeristy of Kelaniya"
---
>                     "any": "Faculty of Medicine, University of Kelaniya"
$ 

Rationale for the changes in the JSON file:

pauldekkers commented 9 months ago

The JSON file is basically a cached version of what is provided by the institutions themselves via eduroam CAT. That's really the place where the institution administrators should fix these values. Making these modifications in the repository here does not make sense.

DimitriPapadopoulos commented 9 months ago

Is there a way for a 3rd party to suggest changes, or are changes exclusively initiated by the administrators of either site?

DimitriPapadopoulos commented 9 months ago

I reverted the change to the JSON file.

johankool commented 9 months ago

Thanks @DimitriPapadopoulos