search

geteduroam / ionic-app

iOS and Android app for geteduroam
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Update clientId #47

Closed jornane closed 4 years ago

jornane commented 4 years ago

We have created a new Client ID for the app. This change is really simple, but it comes with a twist.

There is a server-side mitigation for #31 in the server-side code that only works for the old Client ID. When this pull request is merged, the mitigation is deactivated and the bug is triggered. Because of this, this PR cannot be merged before #31 is resolved.

jornane commented 4 years ago

It seems that #50 also blocks this PR

jornane commented 4 years ago

It seems that #51 also blocks this PR

jornane commented 4 years ago

Will be merged by #66