search

geteduroam / linux-app

geteduroam Linux client
BSD 3-Clause "New" or "Revised" License
19 stars 3 forks source link

Merge to GUI branch: Replace TreeViews with ListViews + add profile selection screen #22

Closed jwijenbergh closed 1 year ago

jwijenbergh commented 1 year ago

Pr because I want a confirmation that this indeed fixes the height padding. Note that I still have a margin set now but this can easily be removed.

Only problem is that we can still scroll horizontally but maybe that is wanted to see too long entries.

You might also notice that the filtering is different now, that is because we were still using the reversed filtering from the CLI in the other GUI branch. This fixes that. But due to this you might notice that we really need a good scoring system. Typing eva gives mostly garbage. The fact that it was previously on top is a coincidence because it is the last entry in discovery that contains the eva string

For a functioning GUI the main part that is missing is a help screen/about dialog, good error handling (we mostly panic now), some more beautification and an authorization screen for OAuth

mrvanes commented 1 year ago

Much better than TreeView. I too, can scroll the list sideways but it's not obvious at first sight and doesn't bother me. A font-size of 14px looks a lot better to me, but I like my fonts small and concise ;)

jwijenbergh commented 1 year ago

Thanks for testing so quickly, maybe font size should be configurable (although maybe it makes more sense to leave that to a global setting for all apps)