search

geteduroam / linux-app

geteduroam Linux client
BSD 3-Clause "New" or "Revised" License
19 stars 3 forks source link

Login: Fix invalid toast unref #30

Closed jwijenbergh closed 1 year ago

jwijenbergh commented 1 year ago

We should only unref the overlay as the reference count for the toast is not increased. This could crash the app when you close the toast

jwijenbergh commented 1 year ago

Good catch, but I can't check correctness.

Yes it's difficult and I think these things should all be handled by the lib maybe, but I could get the main app to crash if I clicked on the "x" button to close the toast (first get a warning then a crash the second time)