search

geteduroam / linux-app

geteduroam Linux client
BSD 3-Clause "New" or "Revised" License
19 stars 3 forks source link

NM: Store password using the user keyring #7

Closed jwijenbergh closed 3 months ago

jwijenbergh commented 1 year ago

This prevents the password from being used by other users. I think it's good that this is off by default

See https://people.freedesktop.org/~lkundrak/nm-docs/nm-settings.html#secrets-flags

and

https://github.com/GEANT/CAT/issues/264

jwijenbergh commented 1 year ago

Will need to test what happens if you don't have a keyring, my assumptions are that it will keep asking for passwords. I think we should detect if the user has a keyring, if that is not the case we show a warning. Hence the draft for now

Lukas-UAUX commented 1 year ago

Hi, just tested the pre-release App, it is really nice! Is this setting here still on the radar?

jwijenbergh commented 1 year ago

Hi, just tested the pre-release App, it is really nice! Is this setting here still on the radar?

Hi Lukas, did you test the CLI or GUI? I'm glad it works.

This setting is definitely still on the radar. The problem with enabling it by default is that (in my testing) if you have no keyring (or a non-functioning one), NetworkManager just sets an empty password without warning the user (well you just get an invalid credentials popup) or instructing us something went wrong. I think we need some detection in this client whether or not the keyring works and if it does enable the NM setting

jwijenbergh commented 3 months ago

Closing for now, need to revisit this some other time