geteduroam / windows-app

Windows application for geteduroam
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Make checking the CA non-optional #36

Closed jornane closed 2 years ago

jornane commented 2 years ago

The code has a notion of a "strict mode", which indicates whether server name and CA thumbprint should be validated. These should always be validated, so the flag is not needed.

However, in removing this, I found that there is an inconsistency in the code how it handles TTLS-MSCHAPv2 and TTLS-(P)EAP-MSCHAPv2. The inconsistency is about validation of server names and CA in the inner authentication; this may not be necessary, and might not even be possible.

Please check this branch with both TTLS-MSCHAPv2 and TTLS-(P)EAP-MSCHAPv2.