geteduroam / windows-app

Windows application for geteduroam
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Enable server name validation #47

Open devon-mar opened 1 month ago

devon-mar commented 1 month ago

Currently AcceptServerName is always false which does not validate the server's name against ServerNames (which is already set). If a public CA is configured, an attacker could simply obtain a certificate obtained by the same CA and spoof the RADIUS server. The client would trust this server since it only validates that the certificate was issued by an allowed CA, NOT the server name.

This PR changes AcceptServerName to be true when at least one server name is given.

https://learn.microsoft.com/en-us/windows/win32/eaphost/eaptlsconnectionpropertiesv1schema-tlsextensionstype-peapextensionstype-element