getezy / ezy

🔥 GUI client for gRPC/gRPC-Web
https://getezy.dev
Mozilla Public License 2.0
974 stars 16 forks source link

feat: add authority header setup capability #50

Open nicholasxuu opened 1 year ago

notmedia commented 1 year ago

Hi, thank you for opening this PR! I have some points we need to discuss:

  1. Could you elaborate about your case and infrastructure, why you need this option? I want to reproduce it and make some tests.
  2. If the grpc.default_authority is set you are also setting the same value to the grpc.ssl_target_name_override option. I think this can break some scenarios where the values might be different. But need investigate this, for example - https://github.com/grpc/grpc-node/issues/655
  3. I moved grpc-client from this project to separate library - https://github.com/getezy/grpc-client where I will add this option too after investigating.