getfider / fider

Open platform to collect and prioritize feedback
https://fider.io
GNU Affero General Public License v3.0
2.75k stars 620 forks source link

[BUG] Empty Deletion Reason Does Not Trigger Delete Webhook #1159

Open BellCubeDev opened 5 months ago

BellCubeDev commented 5 months ago

Couldn't get that out of the team. Best I got was "presumably the latest". I know there's no billing tab in the admin panel so I do believe we're self-hosted.

Describe the bug When deleting a suggestion without providing a reason, deletion webhooks aren't triggered.

To Reproduce

  1. If no deletion event webhook exists, create one. Use the built-in test feature to ensure it works before continuing.
  2. Create a dummy suggestion.
  3. As an admin, enter the delete dialog.
  4. Do not provide a delete reason.
  5. Delete the suggestion.
  6. Check your webhook destination. No webhook event should have been sent.

Expected behavior A webhook event should be sent, even when no deletion reason has been provided. Without these events, knowing whether a suggestion has been removed from an external event log is inconsistent at best.