search

getflip / swirl

Flip's design system to help us work together to build a great experience for all of our customers.
https://swirl-storybook.flip-app.dev/
Other
12 stars 6 forks source link

Possible to upgrade `pdfjs-dist` dependency to 3.x? #373

Open schulzjo-tng opened 1 year ago

schulzjo-tng commented 1 year ago

swirl-components depends on pdfjs-dist 2.16.105:

https://github.com/getflip/swirl/blob/fec6223355a6f6b0b63ea1400c579e42691da204/packages/swirl-components/package.json#L59

That, in turn, depends on dommatrix v1.0.3, which is abandoned: https://www.npmjs.com/package/dommatrix I therefore keep getting warnings every time I run npm install.

This dependency has been removed in version pdfjs-dist v3.0.

Is it possible to upgrade swirl-components to a more recent version of pdfjs-dist, or will that break anything?

Sqrrl commented 1 year ago

Hey. There seem to be some breaking changes. We'll try to upgrade in a future release, but might take a while.