Fix swirl-file-viewer-pdf current page number

[joseabernardes]

Summary

• BSW-118: SwirlFileViewer shows wrong page number

To solve the problem, I changed the strategy that defines the current page. Previously, we defined the current page as the first visible page and, when the user scrolled down to the end of the file, we defined the current page as the last one (actually, that was the bug, because we were defining the second to last page and not the last one). The new strategy defines the current page as the first most visible page, so that when we have two visible pages, the current one is the most visible, which is the standard behaviour in other file viewers, such as Chrome. The only edge case I've found is when we have small pages (height) and we can have two full pages visible at the end of the viewer, it will consider the current one as the first one. From what I've found, this is also what Chrome is considering, so I wouldn't consider it a problem.

If you have any question reach out!

Review Checklist

General

• [x] Changeset added
• [x] The submitted code is organized and formatted according to our 💅 Style Guide.
  • [ ] The code is formatted with Prettier.
  • [ ] There are no linting errors.

For new or updated components

https://swirl-storybook.flip-app.dev/?path=/docs/contributions-merge-publish--page

• [x] The changes do not contain any breaking changes.
• [x] The changes do not introduce new components that don't belong in the library (e.g. non-reusable components, highly specialized components, components including business logic)
• [x] The component documentation is updated.
• [x] The changes meet the 🤖 testing requirements.
  • [ ] New features are tested.
  • [ ] In case of bug fixes, regression tests have been added.
  • [ ] All tests are 🟢.
• [ ] The changes meet the 🧏‍♀️ accessibility requirements.
  • [ ] WCAG 2.1 Level A and Level AA requirements are met.
  • [ ] The Storybook a11y addon shows no errors.
  • [ ] The changes have been tested with a screen reader.
  • [ ] Keyboard controls have been tested, if applicable.
  • [ ] Components implementing form controls (inputs, buttons, selects, etc.) do not use Shadow DOM, and instead use Stencil's scoping mechanism
• [ ] The changes use our 🌈 theming concept.
  • [ ] Design tokens have been used where appropriate.
  • [ ] The component has been visually checked in combination with the "Light" and "Dark" theme.
• [ ] The changes meet our 🌍 internationalization requirements.
  • [ ] No static text is used.
  • [ ] The component doesn't break with longer texts or different text wrappings.
  • [ ] Number, currency and date values can be formatted appropriately.
• [ ] The changes work in all supported browsers and viewports. See 📱 Responsive Design

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

| Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **getflipdev** | ⬜️ Ignored ([Inspect](https://vercel.com/getflip/getflipdev/D3MpeqMSAsAsq1rFCfJ9aqptZWij)) | [Visit Preview](https://getflipdev-git-swirl-file-viewer-pdf-page-number-getflip.vercel.app) | | Aug 12, 2024 9:20am | | **staginggetflipdev** | ⬜️ Ignored ([Inspect](https://vercel.com/getflip/staginggetflipdev/EwAvX2AmKtjjFhtKzuGkJZAztsVY)) | [Visit Preview](https://staginggetflipdev-git-swirl-file-viewer-pdf-page-number-getflip.vercel.app) | | Aug 12, 2024 9:20am |

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-778.westeurope.3.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-778.westeurope.3.azurestaticapps.net