search

getflywheel / local-addon-instant-reload

Instantly Reload changes in your browser during development on a LocalWP site
11 stars 8 forks source link

fix: use filter hook for site overview host row content #9

Closed tihal closed 3 years ago

tihal commented 3 years ago

Summary

This PR fixes a bug that caused the "Site Host" row in the Site Overview tab to disappear if you were using Localhost routing AND you didn't have the Instant Reload addon installed.

There is a sister PR for this in the Core Local repo: https://github.com/getflywheel/flywheel-local/pull/1161

Also bumps the version number to 1.1.0 and Core Local version dependency to 6.1.1.

Technical

This gets rid of the SiteInfoOverviewHostRow component, and replaces it with a filter hook that simply returns the correct content for the Host row.

Screenshots / Text Samples

Instant Reload addon active, running, and displaying the correct site domain using site domain routing mode

Screen Shot 2021-08-09 at 2 22 06 PM

Instant Reload addon active, running, and displaying the correct localhost port using localhost routing mode

Screen Shot 2021-08-09 at 2 09 52 PM

Instant Reload addon active, not running, and displaying correct localhost port using localhost routing mode

Screen Shot 2021-08-09 at 3 44 10 PM

Instant Reload uninstalled and using localhost:

Screen Shot 2021-08-09 at 3 47 29 PM

Reference

https://wpengine.atlassian.net/browse/LOC-2911