search

getgauge / gauge-csharp

Csharp runner for Gauge
https://gauge.org
GNU General Public License v3.0
33 stars 21 forks source link

Pass ExecutionContext to Hook methods #124

Closed imonthercks closed 6 years ago

imonthercks commented 6 years ago

This request adds the ability to pass ExecutionContext to Hook methods as requested in Issue #87.

ExecutionContext has been added to Gauge.CSharp.Lib in order to support both the CSharp and DotNet plugins. The CSharp runner now supports an optional argument of type ExecutionContext for all Hooks.

cla-bot[bot] commented 6 years ago

Thanks for your pull request! Looks like this is your first contribution to Gauge. Before we can look at your pull request, you'll need to sign our Contributor License Agreement (CLA). Please visit https://gauge-cla.herokuapp.com/ to read and sign it.

imonthercks commented 6 years ago

I see that this caused the automated build to fail, but that is likely due to a dependency on the new version of the Gauge.CSharp.Lib library that is a part of this pull request. Should this change be pulled into a separate pull request that simply adds ExecutionContext to the Gauge.CSharp.Lib project, and then once that is released, adjust this PR to reflect the new Gauge.CSharp.Lib version?

imonthercks commented 6 years ago

Pull request #125 has been accepted and merged into master. This PR is now pending the next release of Gauge.CSharp.Lib in order to move this feature forward. Thanks!

cla-bot[bot] commented 6 years ago

Thanks for your pull request! Looks like this is your first contribution to Gauge. Before we can look at your pull request, you'll need to sign our Contributor License Agreement (CLA). Please visit https://gauge-cla.herokuapp.com/ to read and sign it.

gaugeci commented 6 years ago

@cla-bot check if all the contributors of this pull request has signed our CLA.

cla-bot[bot] commented 6 years ago

The cla-bot has been summoned, and re-checked this pull request!

sriv commented 6 years ago

@imonthercks - Gauge.CSharp.Lib v0.7.1 is now released. Would you mind updating this PR, please?

thanks.

imonthercks commented 6 years ago

I should have this updated in the next day or two, and will work on a PR for the dotnet core runner.

C. J.

On Thu, Mar 15, 2018 at 6:06 AM Srikanth notifications@github.com wrote:

@imonthercks https://github.com/imonthercks - Gauge.CSharp.Lib v0.7.1 https://www.nuget.org/packages/Gauge.CSharp.Lib/0.7.1 is now released. Would you mind updating this PR, please?

thanks.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/getgauge/gauge-csharp/pull/124#issuecomment-373339708, or mute the thread https://github.com/notifications/unsubscribe-auth/ABaKsJTA-kzDHURDbS_e6ipyV9m6smfTks5teksggaJpZM4Sg9Ov .

imonthercks commented 6 years ago

@sriv I have committed the changes to this PR to include Gauge.CSharp.Lib 0.7.1, however it appears that the dependency on the nightly build of gauge has caused the build to fail on Travis and Appveyor. I was able to run the full test suite successfully locally.

imonthercks commented 6 years ago

@sriv I see that pull request #126 fixed the Travis and Appveyor builds. Is that issue likely the cause for this PR not building successfully? If so, how does this PR get set to build again?

imonthercks commented 6 years ago

Function tests are now passing, however I have one unit test that I created that I wanted to clean up a bit. Will commit momentarily.

sriv commented 6 years ago

Thanks for the contribution @imonthercks . Appreciate it.

imonthercks commented 6 years ago

@sriv Happy to have this feature added to the C-Sharp runner. Now on to dotnet!