search

getgauge / gauge-dotnet

C# runner for gauge + DotNet standard 6.0-8.0
Apache License 2.0
27 stars 21 forks source link

Add .NET 7 support #194

Closed mpekurny closed 1 year ago

mpekurny commented 1 year ago

Adding .NET 7.0 support and removing .NET Core 3.1 support since 3.1 is no longer under support by Microsoft.

This is my fist contribution to anything on GitHub, so let me know if something isn't correct with how I did this, thanks.

zabil commented 1 year ago

@mpekurny can you sign the DCO?

mpekurny commented 1 year ago

I'm not sure I did that right? I have a verified commit, but it kept the old (unverified) commit?

zabil commented 1 year ago

You'll need to modify all the commit message to have the sign-off line. This is different from verifying a commit

https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for#:~:text=Sign%2Doff%20is%20a%20line,did%20what%2C%20especially%20with%20patches.&text=It%20should%20contain%20the%20user,for%20an%20open%2Dsource%20project.

mpekurny commented 1 year ago

@zabil Is this correct? Both have the sign-off line now.

mpekurny commented 1 year ago

I believe I understand why the tests are not passing. However, if I am right, I don't understand how the tests ever passed in the past. The test calls install.sh which builds both the 6.0 and 7.0 version of the package; however, the test only installs a single version of .NET on the test OS. However, other than which versions, this was the same as the old functionality. Previously, install.sh built both the 3.1 and 6.0 versions, but the test only installed a single version on the test OS.

gaugebot[bot] commented 1 year ago

@mpekurny Thank you for contributing to gauge-dotnet. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.