getgauge / gauge-dotnet

C# runner for gauge + DotNet standard 6.0-8.0
Apache License 2.0
27 stars 21 forks source link

Added scenario retries info params #209

Closed PiotrNestor closed 8 months ago

PiotrNestor commented 8 months ago

@sriv

Support for scenario retries data in ExecutionInfo. This provides scenario execution retries information in the hooks context.

gaugebot[bot] commented 8 months ago

@PiotrNestor Thank you for contributing to gauge-dotnet. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

PiotrNestor commented 8 months ago

@sriv What's the problem with the FTs. There was no hook update this time ...

sriv commented 8 months ago

Think this is related - see this stack trace - https://github.com/getgauge/gauge-dotnet/actions/runs/8157433286/job/22297180629#step:10:1223

PiotrNestor commented 8 months ago

@sriv The problem is then related to currentScenario.Retries in:

activatorWrapper.CreateInstance(executionContextScenarioType, currentScenario.Name, currentScenario.IsFailed,
                    currentScenario.Tags.ToArray(), currentScenario.Retries.MaxRetries, currentScenario.Retries.CurrentRetry)

But this should work OK with the latest gauge, gauge-csharp-lib and gauge-dotnet.

The problem is:

sriv commented 8 months ago

I need to look into this a bit deeper to understand the dependency bottleneck. I am stuck with some travel and work, so might take a few days to settle in and investigate. Apologies for this.

PiotrNestor commented 8 months ago

@sriv I've added logic to handle 'currentScenario.Retries' being null when running FT tests with a previous gauge that is not providing the Retries data. The problem is now that the FT is using too old 'Gauge.CSharp.Lib' (that should be 0.10.1) and missing the updated constructor for 'executionContextScenarioType'. Where is the update point for FT project using the latest 'Gauge.CSharp.Lib'?

PiotrNestor commented 8 months ago

@sriv LSP tests - there is some race condition in the build and run tests cycle.

Error: EPERM: operation not permitted, unlink 'C:\Users\runneradmin\AppData\Local\Temp\gauge-lsp-testanyjlL\gauge_bin\Gauge.CSharp.Lib.dll'

I don't understand why gauge_bin contains a C# dll for a JavaScript test run ...