search

getgauge / gauge-java

Java runner for Gauge
https://gauge.org
Apache License 2.0
91 stars 47 forks source link

Use InheritableThreadLocal in datastores #696

Closed glibas closed 1 year ago

glibas commented 1 year ago

When datastores values are saved in a spec step and retrieved in a child thread e.g. which spanned by awaitability the value is not retrieved from that thread correctly. InheritableTheadLocal solved this issue.

glibas commented 1 year ago

Hi @zabil , @sriv , @saikrishna321 , @NivedhaSenthil could you please have a look? Apologies for tagging you all, looks like the project is not actively worked on lately, so thought this might be missed.

sriv commented 1 year ago

@glibas thanks for sending this across. As you've observed the project definitely needs more love. I have apporved the runs for this PR, once the tests pass I'll be merging this. Post this we need a release. Please bump the version and I'll trigger a release.

gaugebot[bot] commented 1 year ago

@glibas Thank you for contributing to gauge-java. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

glibas commented 1 year ago

Hi @sriv thank you for getting back to me. I've bumped up the version. Looks like some tests are failing on java 17 on windows, the reason, however, looks unrelated to the changes in the PR.

sriv commented 1 year ago

all the tests passed @glibas , but I believe the version bump commit is missing a sign-off. Please see the instructions here to fix this - https://github.com/getgauge/gauge-java/pull/696/checks?check_run_id=13826123761