getgauge / gauge-java

Java runner for Gauge
https://gauge.org
Apache License 2.0
91 stars 47 forks source link

Bump com.google.protobuf:protobuf-java from 3.25.3 to 4.27.1 #815

Closed dependabot[bot] closed 2 months ago

dependabot[bot] commented 2 months ago

Bumps com.google.protobuf:protobuf-java from 3.25.3 to 4.27.1.

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
zabil commented 2 months ago

Upgraded the proto generated files to use the latest version using genproto.sh

zabil commented 2 months ago

It also might be worth bumping up the version and making a release. Can add a commit for that in this PR.

chadlwilson commented 2 months ago

Yeah the major version change and the dependencies with protobufs combined with major version change was main reason I didn't merge this. Didn't spend any time though :)

Was worried it might somehow end up coupled with a gauge release as don't have a sufficient depth of understanding about compatibility. :)

zabil commented 2 months ago

The functional tests pass. I can test this locally see if it works with the latest version of gauge. There is an option to make it only compatible/require the latest version of gauge.

gaugebot[bot] commented 2 months ago

@dependabot[bot] Thank you for contributing to gauge-java. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

zabil commented 2 months ago

Bumped version and compatibility at d8bcbfcb7f0c05f8d57cdd5a2c8df3d43349f7ce

Tested locally with

java --version                                                                                       11:56:28
openjdk 22.0.1 2024-04-16
OpenJDK Runtime Environment Homebrew (build 22.0.1)
OpenJDK 64-Bit Server VM Homebrew (build 22.0.1, mixed mode, sharing)

gauge -v                                                                                             11:56:24
Gauge version: 1.6.7
Plugins
-------
html-report (4.3.1)
java (0.11.0)
js (4.0.1)
screenshot (0.2.0)
ts (0.3.2)
zabil commented 2 months ago

Had to manually push version 0.11.0 to gauge repositories because the sonatype repo tokens expired. I set the new tokens so the next build should be ok.