search

getgauge / gauge-js

JavaScript language plugin for Gauge
MIT License
81 stars 39 forks source link

Fix tests on Node 20.8.0+ #603

Closed chadlwilson closed 8 months ago

chadlwilson commented 11 months ago

mock-fs performs deep mocking on node/fs internals which seems to be rather brittle. And it's broken on Node 20.8.0+ right now.

Based on the changelog at https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md#2023-09-28-version-2080-current-ruyadorno , I am guessing it's some of the changes such as https://github.com/nodejs/node/pull/49593 or https://github.com/nodejs/node/pull/49691

Replaced here with mock-tmp, a simple library that keeps roughly the same API as mock-fs for ease of migration, but uses real files on the filesystem.

gaugebot[bot] commented 8 months ago

@chadlwilson Thank you for contributing to gauge-js. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.