getgauge / gauge-visualstudio

Visual Studio plugin for Gauge
10 stars 9 forks source link

Individual Tags should be highlighted as a part of Syntax highlighting #236

Closed sswaroopgupta closed 6 years ago

sswaroopgupta commented 6 years ago

Expected behavior Tags should be highlighted as given in the image below

tags

Actual behavior The highlight is incomplete

tags_partial_highlight

Version

Gauge version: 0.9.9.nightly-2018-06-01
Commit Hash: 812f26e

Plugins
-------
csharp (0.10.4.nightly-2018-05-29)

VS - gauge.visualstudio-latest.nightly-2018-06-06

sriv commented 6 years ago

The tags are being highlighted, just a different style.

By design, gauge-visualstudio does not dictate the styles, rather it uses the theme's style of literal. Ref: https://github.com/getgauge/gauge-visualstudio/blob/master/Gauge.VisualStudio/Classification/Types.cs#L53.

In this case, VS2017's default theme seems to be using this style. We should not aim for exact styles, since the colour, font styles etc are inherited from the theme, allowing the users to change themes.