search

getgauge / taiko

A node.js library for testing modern web applications
https://taiko.dev
MIT License
3.58k stars 453 forks source link

Boolean highlightOnAction #2584

Closed lufton closed 2 years ago

lufton commented 2 years ago

Breaking change: can't use string highlightOnAction anymore. Instead use boolean.

zabil commented 2 years ago

Can you please sign the DCO?

zabil commented 2 years ago

@NivedhaSenthil @saikrishna321 do you think breaking change is ok?

NivedhaSenthil commented 2 years ago

I feel it is fine as this represents the options in the right way 👍