search

getgauge / taiko

A node.js library for testing modern web applications
https://taiko.dev
MIT License
3.57k stars 453 forks source link

OpenTab adds "http://" to chrome URLs #2644

Closed Ola-German closed 1 year ago

Ola-German commented 1 year ago

Steps to reproduce:

Exprected behavior: openTab to a the chrome URL

Actuall behavior: open a tab to "http://chrome-some_feauture://" Example: image

How to solve it This issue was solved for "goto" but not for "openTab" issue: https://github.com/getgauge/taiko/issues/1720 solved by: https://github.com/getgauge/taiko/pull/1721/files

Please consider adding this functionality to OpenTab as well here:

https://github.com/getgauge/taiko/blob/9b3abf9d9ebaa1ba4cc75e9f5c91858e5960c60d/lib/taiko.js#L385

NivedhaSenthil commented 1 year ago

@Ola-German Thanks for raising this.. please feel free to create a PR will be happy to review it 👍

arun04arun95 commented 1 year ago

@NivedhaSenthil I have raised PR for this issue. Can you please review it ?

https://github.com/getgauge/taiko/pull/2652

marques-work commented 1 year ago

@Ola-German 1.3.5 has been released which includes a fix for this -- does it work for you after updating?

marques-work commented 1 year ago

@NivedhaSenthil close this as it's been merged?