search

getgauge / taiko

A node.js library for testing modern web applications
https://taiko.dev
MIT License
3.56k stars 452 forks source link

Fix some vulnerabilities and other enhancements #2663

Closed marques-work closed 1 year ago

marques-work commented 1 year ago

This looks like changes to some random files (and, to be fair, it is). But there's a lot of context in the commit messages.

In summary, this basically does:

  1. Upgrade documentation@14.0.0
  2. Fix a timezone-flaky test
  3. Document all necessary browser dependencies in the github actions build; on vanilla ubuntu, the list was insufficient
  4. Make linting part of the build and fix lint errors

@NivedhaSenthil could I get a review when you have a moment? I will leave some comments inline to the code for context.

marques-work commented 1 year ago

Hmm, well looks like there are some tests to fix. These didn't fail locally for me. Will get to it tomorrow. Need sleep.

NivedhaSenthil commented 1 year ago

Thanks for taking time to fix this ..I will start reviewing :)

marques-work commented 1 year ago

@NivedhaSenthil I think I need your help; I know this is failing on the netlify build, which is running npm run doc. Running this locally works fine, but maybe netlify is using an older node build that doesn't support dynamic import()?

I don't know how to do a netlify build to reproduce it. I think the CLI needs some auth that I'm sure I don't have access to, but the taiko core team does.

Unfortunately, documentation has moved to es modules only; there are no commonjs builds as far as i can tell. Could you offer some guidance?

zabil commented 1 year ago

@marques-work it is a problem with the node version. I bumped the version to node 18 and got the build to work on netlify.

marques-work commented 1 year ago

Thanks @zabil!

marques-work commented 1 year ago

Whoever sees this next, I think the tests are waiting on approval to run. No rush on it, just don't want it to be missed entirely.

NivedhaSenthil commented 1 year ago

LGTM