getgauge / taiko

A node.js library for testing modern web applications
https://taiko.dev
MIT License
3.56k stars 452 forks source link

Canary update all JS dependencies and update chromium to match #2666

Closed marques-work closed 1 year ago

marques-work commented 1 year ago
marques-work commented 1 year ago

@NivedhaSenthil Whenever you get a chance, could you review this PR?

cc: @zabil

BTW, is there any reason we couldn't support ARM64 chromium, at least for mac_arm platform? M1 macs are becoming more commonplace and it would be snappier to run without Rosetta.

I'd make a separate PR for that, but wanted to double check in case there was some technical reason it wasn't supported. I don't know if there are any other platforms that really need ARM64 -- prob the most common linux on ARM64 is the raspberry PI 4? I don't know the quality (or exact architecture) of the Linux_ARM_Cross-Compile or Arm snapshots (are they arm64 or arm32?).

zabil commented 1 year ago

I'd make a separate PR for that, but wanted to double check in case there was some technical reason it wasn't supported.

I don't think anyone worked on it. It will be good to add support for ARM64 chromium

marques-work commented 1 year ago

@zabil I think Nivedha might be occupied ATM; do you by chance have any cycles to review this PR?