Closed marques-work closed 1 year ago
@marques-work Thank you for contributing to taiko. Your pull request has been labeled as a release candidate 🎉🎉.
Merging this PR will trigger a release.
Instructions to bump the version can found at CONTRIBUTING.md
If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.
Hmm, the merge didn’t seem to create a release? Am I able to view the logs of the bot somewhere?
On Thu, Jan 12, 2023 at 3:51 PM Zabil Cheriya Maliackal < @.***> wrote:
Merged #2676 https://github.com/getgauge/taiko/pull/2676 into master.
— Reply to this email directly, view it on GitHub https://github.com/getgauge/taiko/pull/2676#event-8216159386, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFQVOQ447BG5JZLRGWP3FLWSCKGVANCNFSM6AAAAAATZUELR4 . You are receiving this because you were mentioned.Message ID: @.***>
From netlify, issue with the node function that netlify uses to run webhooks as fetch comes with node 18
Jan 13, 07:50:28 AM: 60bfaaef
ERROR ReferenceError: fetch is not definedJan 13, 07:50:28 AM: 60bfaaef
ERROR at prClosed (/var/task/netlify/functions/webhook.js:46:22)Jan 13, 07:50:28 AM: 60bfaaef
ERROR at /var/task/node_modules/@octokit/webhooks/dist-node/index.js:177:14Jan 13, 07:50:28 AM: 60bfaaef
ERROR at async Promise.all (index 0)Jan 13, 07:50:28 AM: 60bfaaef
ERROR at async Runtime.handler (/var/task/netlify/functions/webhook.js:85:5)
I see - and this is node 16 instead?
On Thu, Jan 12, 2023 at 11:53 PM Zabil Cheriya Maliackal < @.***> wrote:
From netlify, issue with the node function that netlify uses to run webhooks as fetch comes with node 18
Jan 13, 07:50:28 AM: 60bfaaef ERROR ReferenceError: fetch is not definedJan 13, 07:50:28 AM: 60bfaaef ERROR at prClosed (/var/task/netlify/functions/webhook.js:46:22)Jan 13, 07:50:28 AM: 60bfaaef ERROR at @.***/webhooks/dist-node/index.js:177:14Jan 13, 07:50:28 AM: 60bfaaef ERROR at async Promise.all (index 0)Jan 13, 07:50:28 AM: 60bfaaef ERROR at async Runtime.handler (/var/task/netlify/functions/webhook.js:85:5)
— Reply to this email directly, view it on GitHub https://github.com/getgauge/taiko/pull/2676#issuecomment-1381440238, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFQVOTO7O3B3MPAL4QCQGTWSECX3ANCNFSM6AAAAAATZUELR4 . You are receiving this because you were mentioned.Message ID: @.***>
Yes, looks like I need to set an environment variable to use node 18 instead of 16, according to
@marques-work that fixed it! The new release is now out. Thanks for being patient and following up.
Awesome, thanks for all your hard work Zabil! 🎉
On Fri, Jan 13, 2023 at 2:14 PM Zabil Cheriya Maliackal < @.***> wrote:
@marques-work https://github.com/marques-work that fixed it! The new release https://github.com/getgauge/taiko/releases/tag/v1.3.8 is now out. Thanks for being patient and following up.
— Reply to this email directly, view it on GitHub https://github.com/getgauge/taiko/pull/2676#issuecomment-1382453855, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFQVOXVOEEQTWFHOZS6C53WSHHVLANCNFSM6AAAAAATZUELR4 . You are receiving this because you were mentioned.Message ID: @.***>
Bumping to 1.3.8 + updating packages.
cc: @zabil