search

getgrav / grav-learn

Grav Learn (exhaustive grav documentation)
http://learn.getgrav.org
MIT License
229 stars 785 forks source link

List field item placement property #901

Closed Karmalakas closed 3 years ago

Karmalakas commented 3 years ago

This adds description for placement property for List field. It was newly added to Admin and Flex Object plugins. PRs are here for Admin and here for Flex

Probably shouldn't be merged before the mentioned PRs are merged

rhukster commented 3 years ago

cheers

Karmalakas commented 3 years ago

Just thought, that instead of placement: position it would maybe be more clear to have placement: button or button_position. @rhukster, what do you think? Is it too late?

w00fz commented 3 years ago

I really appreciate you putting the time into adding the docs as well.

Also, I think placement: position is fine, if this turns out to be confusing, we could add a property functioning as alias but frankly I think 1 attribute is just fine to serve this purpose.

Thank you!