.inline css in iconpicker.css file hides inline labels in some form items

getgrav / grav-plugin-admin

Grav Admin Plugin

http://getgrav.org

MIT License

355 stars 225 forks source link

.inline css in iconpicker.css file hides inline labels in some form items #1199

Closed madhaze closed 6 years ago

madhaze commented 7 years ago

It looks like the .inline css is hiding unexpected things elsewhere that is using that same class. https://github.com/getgrav/grav-plugin-admin/blob/develop/themes/grav/css/iconpicker.css#L82

Inline labels used for radio buttons are now hidden due to the above css. This needs to be refactored to not use such a generic class or something to avoid other things getting hidden that also use the .inline class.

screenshot 2017-08-18 11 52 30

rhukster commented 7 years ago

Fixed in develop branch. Please test to confirm.

madhaze commented 7 years ago

@rhukster Thanks for the quick fix. I downloaded and tested.

No longer seeing the .inline items hidden.
I didn't test anything with iconpicker. I haven't used that not sure what to test on that end. 👍

rhukster commented 7 years ago

Great, will be in the next release.