[Enhancement request] Deleting plugin should remove yaml from config/plugins

getgrav / grav-plugin-admin

Grav Admin Plugin

http://getgrav.org

MIT License

354 stars 227 forks source link

[Enhancement request] Deleting plugin should remove yaml from config/plugins #1620

Open jgonyea opened 5 years ago

jgonyea commented 5 years ago

When removing a plugin via the admin gui's delete button, I think the corresponding plugin's yaml file from user/config/plugins should also be removed from the filesystem. This would prevent confusion on future installations of that plugin.

jgonyea commented 4 years ago

This should probably be handled "upstream" in grav core, not just admin, as users may use the bin/gpm to uninstall items as well.

mahagr commented 4 years ago

I think ideally there should be two ways to remove a plugin: full uninstall (purge) and partial uninstall, which keeps data and the configuration of the plugin intact in case of you need it later.

So yes, we also need to be able to delete all the other files which were added by the plugin. Should we add something to the blueprint file, so that the data locations can be registered, or do we need to add a custom uninstall script support (or both)?

jgonyea commented 4 years ago