Request: Send current selected page to plugins to add/hide page blueprints.

[pamtbaau]

It is quite common for a plugin to check whether it should activate or not by checking the current uri/path against an 'enable_on_routes' config variable.

In Admin, this technique is cumbersome to implement (but doable) because the translated route of the selected page is not easily available.

This leads to the following issues:

• When multiple plugins have page blueprints for the same page type, the tabs-bar get cluttered with tabs for each plugin.
• Also when saving the page, the default data for each plugin gets written into the page's header.

Solution:

• Pass the page selected for editing to the plugin. The Page::route() can then easily be tested against the array of 'enable_on_routes'. When valid, the plugin can call Types::scanBlueprints() to make its blueprints available in the page's tab-bar.

Suggestion:

• Use existing 'onAdminPage' event in AdminPlugin::onPagesInitialized() and add selected page to the event:

  $event = new Event([
    'page' => $page,
    'selectedPage' => $this->admin->page(),
  ]);
  $event = $this->grav->fireEvent('onAdminPage', $event);

• Or create new dedicated event when page is selected.

  $event = $this->grav->fireEvent('onAdminPageSelected', $event);

[mahagr]

The current page logic is getting replaced with Flex Pages in Admin 1.10. It already has support for passing information as an event, though I've not looked into that for a long time and I'm not sure if it still works as intended.

[pamtbaau]

I've cloned admin 1.10 and its required flex-objects plugin.

I don't see much changes of first sight, but in AdminPlugin::initializeAdmin(), line 956 the Admin object is initialized. At that moment, Admin::page() returns the page selected by the user for editing.

That seems to me the right moment to fire an event containing the page.

On a side note: Admin 1.10 + flex-objects plugins seems to be much more responsive...

[mahagr]

The current version of flex plugin does not enable flex pages admin, it's enabled in the next version. You need to enable it from the plugin. Flex never calls Admin::page(). :)