search

getgrav / grav-plugin-admin

Grav Admin Plugin
http://getgrav.org
MIT License
355 stars 227 forks source link

Save Failed: fatal: empty ident name (for ) not allowed #2030

Open Ribero opened 3 years ago

Ribero commented 3 years ago

Grav v1.7.1 - Admin v1.10.1

When I try to change the publication status of a page I get this error:

image

At then end the page is correctly Published or not

mahagr commented 3 years ago

I cannot reproduce. Could be a field or a plugin causing this?

Ribero commented 3 years ago

May be, but where to start ? The plugins I use are the one related to learn2-gitsync + nextgen editor + admin revision.

mahagr commented 3 years ago

Start by searching ident name from the page / blueprints. It is supposed to be empty?

Ribero commented 3 years ago

I removed the support for multiple languages (in the main configuration) and the problem disappeared.

mahagr commented 3 years ago

If you enable debugger (use clockwork and install it to your browser), it should have a tab for exceptions, which should have a backtrace where that error happens.

mahagr commented 3 years ago

@Ribero Check if you can still reproduce this error, hopefully in a minimal installation and instructions, thanks!

Ribero commented 3 years ago

Will try to test it asap.

0x01af commented 3 years ago

Hi at all

I had the same issue. The error message is not thrown by Admin, it's from the Grav GitSync plugin. Typically, GitSync pushes changes to the repository by default. I had to configure my SSH-Private-Key in the GitSync plugin configuration page. After that, the error message disappeared for all changes.

I hope, my finding helps you.

boomam commented 2 years ago

I get this issue too, with the container. Tried generating the ssh-keys as noted by @0x01af and having the path to it listed in the GitSync config, same issue.

JasperCiti commented 2 years ago

Did anyone find a solution yet? I also have the same problem. I used a clean installation from the woo template.

nemchik commented 2 years ago

Found a fix that worked for me.

I'm running in a docker container, and I believe the issue is the git user is not picked up because the user running the service inside the container does not have a .gitconfig.

Rather than trying to force the user inside the container to have a .gitconfig, I went to /admin/plugins/git-sync and set Commits Author to Use GitSync Committer Name, which is configured on the same page with the default value GitSync. Side note; I did NOT use a Private SSH Key in the settings (left blank).