search

getgrav / grav-plugin-admin

Grav Admin Plugin
http://getgrav.org
MIT License
355 stars 227 forks source link

Event 'onAdminRegisterPermissions' replaced with oddly named 'PermissionsRegisterEvent::class' event #2310

Open pamtbaau opened 2 years ago

pamtbaau commented 2 years ago

Just curious, why has an oddly event name PermissionsRegisterEvent::class been chosen when deprecating event onAdminRegisterPermissions?

It feels as if code for Grav v1.7.0-rc.4 and Admin v1.10.0-rc.4 hasn't been properly finished...

Wouldn't a name like onAdminPermissionsInitialized be more in line with longstanding event names like:

Would it be possible to replace event name PermissionsRegisterEvent::class with a better one?