Password field in plugin is changed to null on plugin config save

[jgonyea]

Possibly related to https://github.com/getgrav/grav-plugin-admin/issues/249

To Replicate:

• Add a password field to a new plugin's blueprints.yaml.
• Edit the plugin password field to have a password
• Confirm the plugin yaml config contains the password
• Load the Grav admin panel to the plugin configuration form
• Note the password is blank
• Click "Save"

Observed Behavior:

Password field in the plugin is now overridden to null.

Expected Behavior:

Password is left unchanged.

[rhukster]

I think your running into a somewhat known situation.. the password field doesn't show the current password, but there's no other logic to skip if null. Email plugin has a solution to this problem though:

    public function onAdminSave(Event $event)
    {
        /** @var Data $obj */
        $obj = $event['object'];

        if ($obj instanceof Data && $obj->blueprints()->getFilename() === 'email/blueprints') {
            $current_pw = $this->grav['config']->get('plugins.email.mailer.smtp.password');
            $new_pw = $obj->get('mailer.smtp.password');
            if (!empty($current_pw) && empty($new_pw)) {
                $obj->set('mailer.smtp.password', $current_pw);
            }

        }
    }

Basically checks if this is an email plugin save, and if so loads the current stored pw, compares it to the form value. It only updates the password with the new one if the new one is not empty.