getgrav / grav-plugin-admin

Grav Admin Plugin
http://getgrav.org
MIT License
355 stars 222 forks source link

admin.yaml pagemedia resize_quality - best value is 0.99 not 1 #2393

Open kittyfishfrommars opened 5 months ago

kittyfishfrommars commented 5 months ago

Description

.jpg / .jpeg images are not being resized and subsequently displayed in Admin Panel -> Page -> Page Media section, if admin.yaml contains the (erroneous) following line:

pagemedia:
  resize_quality: 1

The correct highest possible value is 0.99.


Cause (apart from my own stupidity)


Proposed solution

update all language strings and documentation (if any)

from RESIZE_QUALITY_HELP: "The quality to use when resizing an image. Between 0 and 1 value." to RESIZE_QUALITY_HELP: "The quality to use when resizing an image. Between 0.01 and 0.99 value."


For reference: