getgrav / grav-plugin-admin

Grav Admin Plugin
http://getgrav.org
MIT License
355 stars 222 forks source link

Menu Modal Toolbar not showing without admin.super permission #2408

Open chraebsli opened 2 months ago

chraebsli commented 2 months ago

I found an issue regarding the toolbar in the menu modal in pages, which is only showing when the user has admin.super permission.

Currently, I only get this modal without the toolbar with let’s say user1: Menu Modal without Toolbar

But with my admin user, I get this modal, with the toolbar: Menu Modal with Toolbar

I tested this with a fresh Grav + Admin installation without any configuration.


Accounts

Here are my account configs (access only)

admin

access:
  site:
    login: true
  admin:
    login: true
    super: true

user1

access:
  admin:
    login: true
    configuration:
      pages: true
    pages: true
Fuficek commented 1 month ago

I've recently stumbled upon this issue myself and is really annoying. I hope it'll get fixed soon. Seems simple to fix.

chraebsli commented 1 month ago

Seems simple to fix.

You're free to open a PR with the fix;)

rhukster commented 1 month ago

Scratch my comments, had the wrong issue up when responding!

rhukster commented 1 month ago

What plugins do you have installed?

What account privs do you have? can you paste a copy of the user's account yaml file? (user/accounts/username.yaml).

I think you might have a plugin installed that is causing a conflict as i can't recreate this.

Fuficek commented 1 month ago

Seems simple to fix.

You're free to open a PR with the fix;)

I'd like to but I'm not that good at PHP :(

pamtbaau commented 1 month ago

@rhukster,

chraebsli commented 1 month ago

Seems simple to fix.

You're free to open a PR with the fix;)

I'd like to but I'm not that good at PHP :(

Same here. If I'd found the file with the modal, I'd try, but haven't found it somehow.