search

getgrav / grav-plugin-comments

Grav Comments Plugin
http://getgrav.org
56 stars 28 forks source link

Solved plugin problems? #77

Open jeremycherfas opened 5 years ago

jeremycherfas commented 5 years ago

I think I may have solved the problem of the plugin not working.

Line 192 originally read $post = isset($_POST['data']) ? $_POST['data'] : [];

However, $_POST as received from the form did not contain any element data. I replaced that line with the admittedly simpler

If (isset($_POST)){
  $post = $_POST;
}

The plugin now works in my installation. I didn't actually fork the plugin, and so am not sure how to file a PR.

I also reversed email and addComment in the process section of comments.yaml to avoid the problem of receiving an email even though the comment was not saved.

This fix works even without language being set.

Heraes-git commented 5 years ago

@jeremycherfas Just tried all what you said, and it doesn't work for me. Nothing is saved in the /data folder.

jeremycherfas commented 5 years ago

I'm afraid I cannot help you. But let me test the comment function on my own site. I get so few comments that I can never be sure that it still works after upgrading Grav.

Later: you're right, I am not receiving comments from my site and nothing is being saved. I need to check first that email sending works, and will then look elsewhere.

Email works fine.

@Romarain have you raised the question in Discord?

Heraes-git commented 5 years ago

@jeremycherfas Yes, I talked about that. But you know, for third-party plugins, people tend to ignore requests that seem more a consequence of our own config that of the plugin itself.

jeremycherfas commented 5 years ago

Not sure what you mean about 3rd party. This plugin is made by the Grav team.