search

getgrav / grav-plugin-email

Grav Email Plugin
http://getgrav.org
MIT License
37 stars 29 forks source link

Inherit options from plugin configuration #39

Closed z38 closed 7 years ago

z38 commented 8 years ago

This patch adds the option to configure cc, bcc, reply_to, body and charset once per site in user/config/plugins/email.yml.

In addition, the options charset and content_type of multiple body parts have the same defaults as if there was only one body part.

flaviocopes commented 8 years ago

Good idea, it also needs an entry to the blueprints.yaml file to make them editable via Admin, and also add a sensible default to email.yaml

z38 commented 8 years ago

Thank you for your feedback. I just added the new options to blueprints.yaml. As all new options are optional and the defaults are already integrated in email.php, email.yaml could remain the same. Nonetheless, it might be helpful to add some defaults to email.yaml. Which options do you have in mind?

z38 commented 7 years ago

In the meantime, I tested the patch on several sites successfully. Do you need me to fix anything before this is ready to get merged? In case you like to keep the current state, please feel free to close this PR.

flaviocopes commented 7 years ago

Sorry for the delay @z38, I merged it in for the next release

z38 commented 7 years ago

No problem at all, thanks for merging!