search

getgrav / grav-plugin-email

Grav Email Plugin
http://getgrav.org
MIT License
37 stars 29 forks source link

mailer.engine vs. mailer.default #7

Closed hctom closed 8 years ago

hctom commented 8 years ago

I just stumbled upon the following: In the blueprint there is mailer.engine defined as a hidden field (which of course results in no configuration options). On the other hand, there is mailer.default, which allows configuration, because it is defined as a select field with options for

In the Email class then the plugins.email.mailer.engine config value is used to initialize the correct mailer (which was introduced in 89274e44c52344710fcd370e3394ea1fc635ef29).

So now I am really confused if something got messed up here? Perhaps the maintainers can have a look at that or give me advice how this should be solved.

hctom commented 8 years ago

Any news on this? I think this should really be fixed soon, because the configuration option in the admin interface does not have any effect right now.

rhukster commented 8 years ago

I was kinda waiting for the dust to settle with all the PRs :) and comments. Also @flaviocopes has been looking into this so figured I would leave this to him.

hctom commented 8 years ago

Okay no problem... and I promise, I will stop bothering when all the other stuff in the PRs is done ;)

flaviocopes commented 8 years ago

I checked the source. In the beginning it was using mailer.default, but now the plugin uses the setting from mailer.engine. So we should remove default and add the select options to engine.

I didn't realize this because I almost always edit the email.yaml file directly, and there default does not exist.

flaviocopes commented 8 years ago

Since https://github.com/getgrav/grav-plugin-email/commit/8013dd249af996cdc63e4b8702f6efd179cff296

rhukster commented 8 years ago

Is this sorted now???

hctom commented 8 years ago

Give me half an hour ;)

hctom commented 8 years ago

See #12