search

getgrav / grav-plugin-error

Grav Errors Plugin
https://getgrav.org
MIT License
4 stars 29 forks source link

Enabling translation of error page title #26

Closed rbukovansky closed 6 years ago

rbukovansky commented 7 years ago

This should resolve #23

rbukovansky commented 7 years ago

@flaviocopes Could you please merge this one as well if it's OK? Thanks.

rbukovansky commented 7 years ago

@flaviocopes OK. Any idea how to do it?

BTW I have updated README in commit as well, stating that change in settings is needed to work properly.

rbukovansky commented 7 years ago

@flaviocopes Have you thought about how to workaround that, please? Thanks.

flaviocopes commented 7 years ago

No I didn't come up with a solution that's generally applicable without breaking backwards compatibility with the current release

rbukovansky commented 6 years ago

@rhukster Why was this merged and then reverted few seconds later?

rhukster commented 6 years ago

Because it broke 'out of the box' due to the requirement to enable Twig processing in frontmatter. This is not an acceptable tradeoff. I think this can be done by setting the title programmatically from the plugin rather than via twig in page frontmatter.

I was in the middle of Grav 1.4 release and didn't have time to fiddle with it.