Use json_encode for JSON feed

getgrav / grav-plugin-feed

Grav Feed Plugin

https://getgrav.org

MIT License

16 stars 11 forks source link

Use json_encode for JSON feed #24

Closed cweiske closed 7 years ago

cweiske commented 7 years ago

JSONfeed shall be "difficult to do wrong." (see https://jsonfeed.org/version/1).

Unfortunately, the plugin does not use json_encode which would take care of all escaping, but creates the JSON manually. This is why rss/atom feeds broke: People built XML manually.

You're repeating history here with #21. Please do it better this time.

rhukster commented 7 years ago

how about next time, instead of making a rude remark that belittles other contributions you simply submit a PR and contribute yourself?

cweiske commented 7 years ago

Yeah right. Simply say in your README that you do not want bug reports.

cweiske commented 7 years ago

oh look: #25