getgrav / grav-plugin-feed

Grav Feed Plugin
https://getgrav.org
MIT License
16 stars 11 forks source link

Feed not loading after upgrading to 1.8.3 #62

Closed doryiii closed 3 years ago

doryiii commented 3 years ago

I don't recall what the last version was, but I recalled it was working back in Sep 2020.

After upgrading to grav 1.7.15 and feed 1.8.3, the feed URLs no longer works. Before, going to https://bakkin.moe/home.rss would load the RSS feed for the home blog content; however, now it just brings up the actual blog HTML page.

No config has been changed since June 2020, including during the recent upgrade.

rhukster commented 3 years ago

Are you sure you are on Feed v1.8.3? That has a fix that specifically addresses the issue you are describing.

if so, then could I get a copy of your homepage .md file? Perhaps it has a different configuration I'm not taking into account. Cheers.

doryiii commented 3 years ago

Yes, I am running Feed v1.8.3 image

my user/pages/01.home/blog.md:

---
title: Home
visible: true
content:
    items: '@self.children'
    order:
        by: date
        dir: desc
    limit: 10
    pagination: true
    filter:
        visible: true
annewsment:
    items:
        -
            '@page.self': /annewsment
    filter:
        visible: true
---
Sasumotu commented 3 years ago

Got the same problem since 1.8.2. 1.8.3 also didn't fix it for me.

frontpage.md:

---
title: Home
sitemap:
    changefreq: monthly
content:
    items: '@self.children'
    order:
        by: date
        dir: desc
    limit: 5
    pagination: true
feed:
    limit: 10
pagination: true
cache_enable: false
---
rhukster commented 3 years ago

can you guys send me a zip of a test setup where this happens for you? I can't replicate it with my setups

Sasumotu commented 3 years ago

I tried to reproduce it in a local LAMP environment with my website but there everything worked fine.

So I started suspecting that it is some kind of problem with my shared hosting provider. They are using apache2 with nginx as a reverse proxy as the default setup. If I disable nginx and all requests are served via apache2 the rss feed is working as expected.

utagawal commented 3 years ago

Hello,

Same behavior here, the rss page doesn't load anylonger, instead it shows the html page.

You can check on https://blog.utagawavtt.com and https://blog.utagawavtt.com/fr/blog.rss

doryiii commented 3 years ago

I'll set up a test instance when I get home and send that over if I can reproduce the issue over there.

rhukster commented 3 years ago

@utagawal https://blog.utagawavtt.com/fr/blog.rss is totally showing the RSS feed output.

<? xml version = "1.0" encoding = "utf-8"?>
<rss xmlns: atom = "http://www.w3.org/2005/Atom" version = "2.0">
    <channel>
        <title> UtagawaVTT - Articles </title>
        <link> https://blog.utagawavtt.com/en </link>
        <atom: link href = "https://blog.utagawavtt.com/fr/blog.rss" rel = "self" type = "application / rss + xml" />
        <description> The latest posts from the UtagawaVtt blog </description>
        <language> en </language>
        <lastBuildDate> Sat, 05 Jun 2021 11:50:00 +0200 </lastBuildDate>
                        <item>
            <title> The top GPS connected watches for mountain biking </title>
            <link> https://blog.utagawavtt.com/fr/blog/top-montres-gps </link>
            <guid> https://blog.utagawavtt.com/fr/blog/top-montres-gps </guid>
            <pubDate> Sat, 05 Jun 2021 11:50:00 +0200 </pubDate>
            <description>
                <! [CDATA [
                                <img alt = "" src = "https://blog.utagawavtt.com/images/7/4/4/0/8/74408c65a359cce94a424b84723e0ce27662b96c-suunto-9-mtb.jpg" />
                                <p> <span class = "dropcaps dropcaps-c"> C </span> choose a GPS watch for mountain biking without making a mistake? </p>
<p> With their large color screens (sometimes with even full mapping), their functionality and all the sensors that can be paired with them, some GPS watches can now largely take the place. ; a mountain bike GPS and / or bicycle computer. </p>
<p> However, ... </p>
....
utagawal commented 3 years ago

Yes because we had to revert to feed plugion version 1.8 on our production system

Le lundi 7 juin 2021 à 23:03:46 UTC+2, Andy Miller ***@***.***> a écrit :  

@utagawal https://blog.utagawavtt.com/fr/blog.rss is totally showing the RSS feed output.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

rhukster commented 3 years ago

I just released a new 1.8.4 version that has better matching support for multilang. I've also added a new enable_url_check to the config so that can be turned off in a pinch. The new matching logic should be better for all conditions and I tested it with a variety of setups. This check ensures that the RSS logic is not processed unless it needs to be. It will provide a performance improvement to all pages so it's worthwhile getting it working.

utagawal commented 3 years ago

Hi, tested 1.8.4 same behavior, but made it work by going to /fr/blog.rss instead of /blog.rss. Was the route changed between 1.8 et 1.8.x ?

Le lundi 7 juin 2021 à 23:42:24 UTC+2, Andy Miller ***@***.***> a écrit :  

I just released a new 1.8.4 version that has better matching support for multilang. I've also added a new enable_url_check to the config so that can be turned off in a pinch. The new matching logic should be better for all conditions and I tested it with a variety of setups. This check ensures that the RSS logic is not processed unless it needs to be. It will provide a performance improvement to all pages so it's worthwhile getting it working.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

rhukster commented 3 years ago

You can also try the disabling of that enabled_url_check option

rhukster commented 3 years ago

BTW, just checked on my local multilang blog setup, and /.rss + /blog.rss work for default lang (en), fr/.rss +fr/blog.rss work for french.

en/.rss and en/blog.rss don't work because I have include_default_lang set to false. If i set this value to true, then those do work.

This is as expected.

rhukster commented 3 years ago

I've decided to roll back this 'checking' functionality as it really doesn't add much at this point, and causes more issues than it solves. 1.8.5 should be good.

jgonyea commented 2 years ago

Can we reopen this? I think 1.8.5 still has this issue. I rolled back to 1.8.0 and the RSS feed displayed as expected (I'm using a custom feed.rss.twig file via the podcast plugin), but 1.8.5 just renders the html page.

jgonyea commented 2 years ago

When I "git bisect", the issue arises from the "bad" commit 52ddd0d2474e4d381cf81b113e98a55e1f885fea : "fixed issue with json feed type corrupting other json requests getgrav/grav-premium-issues#102"

jgonyea commented 2 years ago

Happy to provide a zip of my example pages, if you need it @rhukster