search

getgrav / grav-plugin-highlight

Grav Highlight Plugin
https://getgrav.org
MIT License
29 stars 11 forks source link

Line numbers not working #14

Closed boredomwontgetus closed 6 years ago

boredomwontgetus commented 6 years ago

I use a pretty vanilla version of grav and the plugin works as expected but not for line numbers.

highlight: lines: true

Does not change anything. Line numbers are just not displayed.

I tested this on multiple themes.

rhukster commented 6 years ago

This was a user contributed PR https://github.com/getgrav/grav-plugin-highlight/pull/12

@OleVik can you shed any light? cheers.

OleVik commented 6 years ago

@boredomwontgetus What errors are you getting in the browser's console? The highlightjs-line-numbers.min.js-file is a tiny addition known to be compatible with highlight.js, but debugging requires a bit more information: What version of Grav, the Highlight-plugin, and your theme are you currently using?

boredomwontgetus commented 6 years ago

@OleVik Thats the thing that confuses me a bit...I dont get any errors in the Browsers (chromium) console.

Grav v1.3.7 Highlight Plugin v1.3.1 Theme Bootstrap v1.6.0

Thanks for your quick response

boredomwontgetus commented 6 years ago

Ok! Looking at the PR linked by @rhukster it looks like this was introduced in Highlighter version 1.3.2. So, I guess an update should do. Will try that tomorrow.

OleVik commented 6 years ago

Indeed, it was released with 1.3.2, which seems to not be entirely released. @rhukster I bumped the version in the PR, but release has not been made for 1.3.2; wanna add a date to that changelog and release it? Should be May 29th.

rhukster commented 6 years ago

I've just release v1.3.2

boredomwontgetus commented 6 years ago

Thank you! Works as expected in 1.3.2. Sorry for raising an issue. I should have gone through the PRs first.

rhukster commented 6 years ago

No prob, actually did raise the issue that we had a release pending :)