search

getgrav / grav-plugin-highlight

Grav Highlight Plugin
https://getgrav.org
MIT License
29 stars 11 forks source link

highlight.js outdated #22

Closed archfrog closed 4 years ago

archfrog commented 5 years ago

Thanks for this plugin, which is crucial for me as I often publish code.

I can see that the highlight.js demo has a style/theme that I'd love to use, but which isn't included in the Grav Highlight plugin.

Any chance that you can update the plugin to use the most recent version of highlight.js?

If not, do you accept sensible pull requests? I already manually added the new styles to my project but only spent energy on adding the A 11 Y Dark style/theme to blueprints.yaml as that was the one I was looking for.

P.S. I assume I'll have to redo my local patches once you make a new version, but that's life :-)

apiontek commented 4 years ago

I second this - I'd prefer to be able to use the "Night Owl" style, unavailable in the current plugin version.

rhukster commented 4 years ago

Update it and submit a pull request. I'll merge...

dgellow commented 4 years ago

@rhukster I believe this issue can now be closed, following the merge of #24

rhukster commented 4 years ago

Yup, new version released