search

getgrav / grav-plugin-lightslider

Grav LightSlider Plugin
https://getgrav.org
MIT License
14 stars 15 forks source link

setting 'controls: false' does not disable controls #2

Closed kat05 closed 9 years ago

kat05 commented 9 years ago

in the shop skeleton site, changing:

controls: true to controls: false in ../user/pages/slider/lightslider.md

does not disable the controls.

rhukster commented 9 years ago

Does it work with:

controls: 'false'

Seems JavaScript is looking for the string 'false' where as php is treating false as 0

kat05 commented 9 years ago

controls: 'false'

seems to work fine.

maybe the default in the lightslider.md can be updated from controls: true to controls: 'true'

?

rhukster commented 9 years ago

Yup, will definitely do that. Also will set the blueprints to be clear on this. Thanks!