getgrav / grav-plugin-login

Grav Login Plugin
http://getgrav.org
MIT License
44 stars 54 forks source link

"Redirect after activation" missing from config file #224

Closed Bennycopter closed 4 years ago

Bennycopter commented 4 years ago

The login.yaml file is missing the config option user_registration.redirect_after_activation.

The option is referenced in login.php on line 374, and it seems to be fully functional... it's just missing from the config file.

rhukster commented 4 years ago

You can submit a PR by going here: https://github.com/getgrav/grav-plugin-login/blob/develop/login.yaml

clicking edit, make your addition and saving. it will create a PR automatically.

Bennycopter commented 4 years ago

Thank you! I'm new to GitHub, so I didn't know about that. I made the pull request.

rhukster commented 4 years ago

I think you missed the last step where it says "create pull request" in a green button? You probably have a local clone of grav-plugin-login repo, and if you go there, it should prompt you.

rhukster commented 4 years ago

https://github.com/Bennycopter/grav-plugin-login

Make the changes to the file directly here, then you should see the green button to create the pull request. Thanks!

Bennycopter commented 4 years ago

I think I got it this time :)

mahagr commented 4 years ago

Looks like this has already been fixed.