Forgot password function – wrong error message

[kvanderloock-site-works]

I got the following issue:

When i try to reset my passwort with a non existing email address there is a info message, that the reset introduction is sent.

The code in the Controller.php (Line 367) is the following:

if (!$user || !$user->exists()) {
  $messages->add($language->translate('PLUGIN_LOGIN.FORGOT_INSTRUCTIONS_SENT_VIA_EMAIL'), 'info');
  $this->setRedirect($this->login->getRoute('forgot') ?? '/');

  return true;
}

but if the user don't exist it should be:

if (!$user || !$user->exists()) {
  $messages->add($language->translate(['PLUGIN_LOGIN.FORGOT_USERNAME_DOES_NOT_EXIST', $email]), 'error');
  $this->setRedirect($this->login->getRoute('forgot') ?? '/');

  return true;
}

in addition to the functionality there is an issue with the german label (de.yaml - line 26):

FORGOT_USERNAME_DOES_NOT_EXIST: "Der Benutzer mit dem Benutzername <b>%s</ b> existiert nicht."

should be:

FORGOT_USERNAME_DOES_NOT_EXIST: "Der Benutzer mit dem Benutzername <b>%s</b> existiert nicht."

Best regards Kevin

[rhukster]

Is it possible to get a Pull Request for this?

[kvanderloock-site-works]

Created a Pull Request. Hope i did it correctly. It's my first time working in a shared repository. If something is not correct, please tell me!

[rhukster]

looks good to me, merged! thanks.