search

getgrav / grav-plugin-markdown-notices

Grav Markdown Notices Plugin
https://getgrav.org
MIT License
33 stars 21 forks source link

CSS corrections #5

Open aleskl opened 7 years ago

aleskl commented 7 years ago

Thank you for the useful plugin that generates really nice code!

However, the style-sheet was not rendering notices correctly - paddings were off, especially top padding. Below is the corrected assets/notices.css to generate notices that are more similar to the original looks achieved by nested blockquotes. Border settings were moved to the .notices class, margin for paragraph is set to 0 and only border-color is left in the color classes:

.notices { padding: 15px; margin: 1rem 0; border-width: 1px 1px 1px 10px; border-style: solid; border-radius: 3px; }

.notices p { margin: 0; }

.notices.yellow { border-color: #f0ad4e; background: #fcf8f2; color: #df8a13; }

.notices.red { border-color: #d9534f; background: #fdf7f7; color: #b52b27; }

.notices.blue { border-color: #5bc0de; background: #f4f8fa; color: #28a1c5; }

.notices.green { border-color: #5cb85c; background: #f1f9f1; color: #3d8b3d; }

rhukster commented 7 years ago

Would it be possible to create a Pull Request with these changes? Simply edit the file in GitHub make your changes, save, click green pull request button, submit :)

aleskl commented 7 years ago

Thank you for instructions! I created a pull request with modifications in notices.css. This is the first time I'm using Git to edit code, so I hope I didn't mess up something :)

Cheers, Ales

2017-09-28 0:11 GMT+02:00 Andy Miller notifications@github.com:

Would it be possible to create a Pull Request with these changes? Simply edit the file in GitHub make your changes, save, click green pull request button, submit :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/getgrav/grav-plugin-markdown-notices/issues/5#issuecomment-332670491, or mute the thread https://github.com/notifications/unsubscribe-auth/ACRGcM_g-3eY17uF-9Oso8ZWeOwGeyxHks5smsgCgaJpZM4Pl7rr .

tcyrus commented 6 years ago

@rhukster, Since the Pull Request (#6) has been merged, this should be closed.