Closed cabrero closed 8 years ago
Thanks @cabrero, I tried but I cannot find any difference, nor the problem it fixes, can you tell me a quick way to reproduce the problem that this PR fixes? Thanks!
Actually this PR will cause issues if you paginate a homepage that is no in a sub directory. I think you will find that testing with Blog skeleton in a vhost would replicate the issue.
I can't replicate this. i've tried in a blog page that has a path: http://localhost/blog
and one with no path: http://blog.dev
, both give me a link to /
back to the first page.
Are you sure you have the latest version???
Hi, Thanks for your work and quick answer.
You're right, the patch will break pagination when in a subdirectory.
Also it was my fault, the problem is not the grav code but the webserver. I only can replicate the issue with the php integrated server. No problem with a "real" server.
-- david
2015-11-21 1:01 GMT+01:00 Andy Miller notifications@github.com:
Are you sure you have the latest version???
— Reply to this email directly or view it on GitHub https://github.com/getgrav/grav-plugin-pagination/pull/12#issuecomment-158563020 .
Link to first page was rendered as href="". This caused browsers to transalte it as "/page:2"